Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui enhancements [35, 36, 37] #39

Merged
merged 2 commits into from
Feb 1, 2024
Merged

feat: ui enhancements [35, 36, 37] #39

merged 2 commits into from
Feb 1, 2024

Conversation

nblenke
Copy link
Contributor

@nblenke nblenke commented Feb 1, 2024

Description

  • 35: update file drop presentation
  • 36: add tooltips to create deployment forrm
  • 37: add discord link to footer
  • 38: fiix nested paragraph warning on terms

Related Issue

Fixes # (issue)

Testing

Breaking Changes (if applicable)

Screenshots (if applicable)

Checklist:

  • I have read and followed the CONTRIBUTING guidelines for this project.
  • I have added or updated tests and they pass.
  • I have added or updated documentation and it is accurate.
  • I have noted any breaking changes in this module or downstream modules.

@nblenke nblenke self-assigned this Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (8f83925) 52.56% compared to head (5a1208e) 52.67%.

Files Patch % Lines
components/create-deployment.tsx 12.50% 5 Missing and 2 partials ⚠️
components/file-upload.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   52.56%   52.67%   +0.11%     
==========================================
  Files          21       22       +1     
  Lines         449      467      +18     
  Branches       58       61       +3     
==========================================
+ Hits          236      246      +10     
- Misses        196      202       +6     
- Partials       17       19       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmorency fmorency self-requested a review February 1, 2024 19:01
Copy link
Contributor

@fmorency fmorency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nblenke! I pushed a small fix, LGTM otherwise.

@fmorency fmorency merged commit c287f13 into liftedinit:main Feb 1, 2024
5 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants