Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing headers #107

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Add missing headers #107

merged 2 commits into from
Jun 30, 2022

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented Jun 28, 2022 •
edited

There were a lot of missing headers. This should eventually be updated with the script that updates sleigh files and the commit sha but I'll leave that for a later time.

This does not include any of the bfd headers because we don't build with bfd support

@ekilmer ekilmer marked this pull request as ready for review June 28, 2022 17:19
@ekilmer ekilmer requested a review from tetsuo-cpp June 28, 2022 17:19
@ekilmer ekilmer mentioned this pull request Jun 28, 2022
Merged
tetsuo-cpp
tetsuo-cpp approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tetsuo-cpp tetsuo-cpp merged commit 60f5ab4 into master Jun 30, 2022
@tetsuo-cpp tetsuo-cpp deleted the add-missing-headers branch June 30, 2022 05:49
@tetsuo-cpp tetsuo-cpp mentioned this pull request Jul 3, 2022
Open
ekilmer added a commit that referenced this pull request Jul 7, 2022
@ekilmer
Merge branch 'master' into cmake-presets
7b8584a 
* master:
  Add missing headers (#107)
  Update Ghidra HEAD to commit d2883bbb8 (#102)
@tetsuo-cpp tetsuo-cpp mentioned this pull request Aug 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetsuo-cpp tetsuo-cpp tetsuo-cpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekilmer @tetsuo-cpp