Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is() removed in lift 3.0 #4

Closed
hglaude opened this issue Jun 6, 2014 · 4 comments · Fixed by #5
Closed

is() removed in lift 3.0 #4

hglaude opened this issue Jun 6, 2014 · 4 comments · Fixed by #5

Comments

@hglaude
Copy link

hglaude commented Jun 6, 2014

Hello,

The module make intensive use of net.liftweb.mapper.MappedField.is() which doesn't exist anymore.

@fmpwizard
Copy link
Member

thanks, I'll send a PR soon

@karma4u101
Copy link
Member

is() should be replaced with get().
You are welcome to make a pull request and open a discussion on the Lift mailing list / forum.
At least I think open a discussion on the mailing list is common practice, but I am not sure its needed, is it ?

fmpwizard added a commit that referenced this issue Jun 6, 2014
Changed default lift version value to `2.5.1`
@karma4u101
Copy link
Member

That was quick :) LGTM

fmpwizard added a commit that referenced this issue Jun 6, 2014
Fixed #4 - use `.get` instead of `.is` which was removed in Lift 3.0
@fmpwizard
Copy link
Member

The jars for lift 3.0-M1 are ready for testing at

https://oss.sonatype.org/content/repositories/snapshots/net/liftmodules/machine_3.0_2.10/1.2-SNAPSHOT/

if you are using sbt, you may need to

rm -rf ~/.ivy2/cache/net.liftmodules

and then start sbt on your project again to get the latest jars

P.S. if you are using Lift 3.0, remember to set the version to 3.0-M1 as the snapshot version will get some breaking changes in the coming weeks

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants