refactor: Improve VPP handler versions and add VPP proxy support #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ondrej-fabry
commented
Dec 17, 2019
•
ondrej-fabry
commented
- add VPP proxy support for remote access to VPP
- improve VPP version resolution and make it more robust
- compatible version is now determined by checking all messages of one binapi version
- add tests for VPP handlers
- cleanup all VPP handlers for consistency
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Codecov Report
@@ Coverage Diff @@
## dev #1593 +/- ##
=========================================
+ Coverage 52.81% 54.1% +1.28%
=========================================
Files 673 372 -301
Lines 79720 31524 -48196
=========================================
- Hits 42105 17055 -25050
+ Misses 34965 13101 -21864
+ Partials 2650 1368 -1282
|
ondrej-fabry
changed the title
rewenset
reviewed
Dec 17, 2019
rewenset
reviewed
Dec 17, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
rewenset
reviewed
Dec 18, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Closed
rewenset
reviewed
Dec 18, 2019
ondrej-fabry
changed the title
rewenset
reviewed
Dec 18, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
golangcibot
reviewed
Dec 19, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.