Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Delete unused REST handler for VPP commands #1677

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

rewenset
Copy link
Contributor

That handler:

func (p *Plugin) commandHandler(formatter *render.Render) http.HandlerFunc {

was moved to govppmux in this PR: #1593.

And from that point (after the PR was merged), new home for the handler is here:

func (p *Plugin) cliCommandHandler(formatter *render.Render) http.HandlerFunc {

@rewenset
Copy link
Contributor Author

rewenset commented Jul 15, 2020

(it is a screenshot, do not click on link)
image
😮

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #1677 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1677   +/-   ##
=======================================
  Coverage   58.07%   58.07%           
=======================================
  Files         366      366           
  Lines       30045    30045           
=======================================
  Hits        17450    17450           
  Misses      11155    11155           
  Partials     1440     1440           
Flag Coverage Δ
#unittests 58.07% <ø> (ø)

@ondrej-fabry ondrej-fabry merged commit 4e9bae6 into ligato:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants