feat: add reading VPP threads to the telemetry plugin #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladoLavor
changed the title
* Added 'GetThreads' for all supported VPP versions in the telemetry vppcalls. Data are read using the binary API (via govppmux) * VPP stats API telemetry handler also has CLI/binapi part in order to read data not yet available in stats * Added simple stats example reading VPP stats via the telemetry plugin TODO: * Fix 'GetMemory' and add it to the example Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
==========================================
- Coverage 55.49% 55.34% -0.15%
==========================================
Files 387 387
Lines 28187 28283 +96
==========================================
+ Hits 15641 15653 +12
- Misses 11028 11112 +84
Partials 1518 1518
Flags with carried forward coverage won't be shown. Click here to find out more. |
* VPP show memory regex now works correctly * Command extended with 'verbose' to match VPPTop requirements Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
ondrej-fabry
previously approved these changes
Oct 23, 2020
|
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the telemetry vppcalls. Data are read using the
binary API (via govppmux)
part in order to read data not yet available in stats
telemetry plugin
match VPPTop requirements
TODO:
Fix 'GetMemory' and add it to the exampleSigned-off-by: Vladimir Lavor vlavor@cisco.com