Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterAnyProblem and FilterAnyProblemStartingWith #171

Closed
2m opened this issue Apr 25, 2017 · 4 comments
Closed

FilterAnyProblem and FilterAnyProblemStartingWith #171

2m opened this issue Apr 25, 2017 · 4 comments
Assignees
@2m
Milestone
0.1.15

Comments

@2m
Copy link
Contributor

2m commented Apr 25, 2017

Akka Http and Akka projects have custom FilterAnyProblem and FilterAnyProblemStartingWith filters that filter issues by path. I propose to migrate these filters to mima sbt plugin, to decrease build code duplication.
@2m 2m added this to the 0.1.15 milestone Apr 25, 2017
@2m 2m self-assigned this Apr 25, 2017
@dwijnand
Copy link
Collaborator

I wonder: are those used to implement the #53 use case?

@2m
Copy link
Contributor Author

2m commented Apr 25, 2017

Yes. For example to ignore everything in the implementation of the akka-http server we would use: FilterAnyProblemStartingWith("akka.http.impl"),

@dwijnand
Copy link
Collaborator

Can't you use #44 for that?

I.e ProblemFilters.excludePackage("akka.http.impl")?

@2m
Copy link
Contributor Author

2m commented Apr 25, 2017

Aha. Bad example from me. Yes, we could use ProblemFilters.excludePackage for that particular case. We started using FilterAnyProblemStartingWith for more fine grained control like internal classes inside objects FilterAnyProblemStartingWith("akka.cluster.pubsub.DistributedPubSubMediator$Internal") and then we drifted towards internal packages without ever discovering ProblemFilters.excludePackage.

2m added a commit to 2m/migration-manager that referenced this issue Apr 25, 2017
@2m
lightbend-labs#171 Add exclude starting with problem filter
e7de869
@2m 2m mentioned this issue Apr 25, 2017
Merged
2m added a commit to 2m/migration-manager that referenced this issue Apr 29, 2017
@2m
lightbend-labs#171 Exclude glob problem filter
0fe054c 
This alse makes excludePackage filter obsolete
and removes it.
2m added a commit to 2m/migration-manager that referenced this issue Apr 29, 2017
@2m
lightbend-labs#171 Exclude glob problem filter
ece8e07 
This alse makes excludePackage filter obsolete
and removes it.
2m added a commit to 2m/migration-manager that referenced this issue Apr 29, 2017
@2m
lightbend-labs#171 Exclude glob problem filter
5ee3eb6 
This alse makes excludePackage filter obsolete
and removes it.
2m added a commit to 2m/migration-manager that referenced this issue Apr 29, 2017
@2m
lightbend-labs#171 Exclude glob problem filter
8d46c68 
This alse makes excludePackage filter obsolete
and removes it.
2m added a commit to 2m/migration-manager that referenced this issue Apr 29, 2017
@2m
lightbend-labs#171 Exclude glob problem filter
ede9aba 
This alse makes excludePackage filter obsolete
and removes it.
2m added a commit to 2m/migration-manager that referenced this issue May 3, 2017
@2m
lightbend-labs#171 Wildcard support in exclude problem filter
af663ed 
This alse makes excludePackage filter obsolete
and removes it.
@2m 2m closed this as completed in #172 May 3, 2017
2m added a commit that referenced this issue May 3, 2017
@2m
Merge pull request #172 from 2m/wip-starting-with-filter-2m
f147e62 
#171 Wildcard support in exclude problem filter
@raboof raboof mentioned this issue Jul 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2m 2m

Labels
None yet
Milestone
0.1.15
Development

No branches or pull requests
2 participants
@dwijnand @2m