Package level whitelisting #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for package level filter such as:
filter {
packages = [
"scala.reflect.internal",
]
}
Changes the config loading to use a default config, to
avoid errors if we load a whitelist that only has one of
`problems` or `packages`.
Tested manually with the build from Scala 2.10.2.
Procedure:
1. Publish modified version of MiMa to my local maven repo:
sbt> set every publishTo := Some(Resolver.file("file", new File(Path.userHome.absolutePath+"/.m2/repository")))
sbt> publish
2. Point to the new version in mima.classpath in scala/scala's build.xml
3. Induce a BC failure (actually its enough to build without -optimize, `ant build test.bc`)
4. Filter this out with `packages = ["scala.xml"]`.
5. Confirm that the problem *isn't* filtered if:
- the `packages` section is omitted entirely
- the `packages` section exists, but is empty
- the `packages` section contains "scala.xm" or "scala.xmllll"
ghost
assigned 
|
@gkossakowski I just made you a member of this repository. I think it make sense to have someone from the Scala team to help with reviews & releases, as you guys are the main MiMa users ;-) |
|
I'm on vacation until Monday. I'll review this either on Monday or Tuesday. |
|
Testing it right now. |
|
Tested successfully. Good work! |
gkossakowski
added a commit
that referenced
this pull request
Aug 30, 2013
Package level whitelisting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for package level filter such as:
Changes the config loading to use a default config, to
avoid errors if we load a whitelist that only has one of
problemsorpackages.Tested manually with the build from Scala 2.10.2.
Procedure:
Publish modified version of MiMa to my local maven repo:
sbt> set every publishTo := Some(Resolver.file("file", new File(Path.userHome.absolutePath+"/.m2/repository")))
sbt> publish
Point to the new version in mima.classpath in scala/scala's build.xml
Induce a BC failure (actually its enough to build without -optimize,
ant build test.bc)Filter this out with
packages = ["scala.xml"].Confirm that the problem isn't filtered if:
packagessection is omitted entirelypackagessection exists, but is emptypackagessection contains "scala.xm" or "scala.xmllll"Review by @gkossakowski