ExplicitNonNullaryApply: workaround for scalameta/scalameta#1083 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and scalacenter/scalafix#1104 Given ``` trait Test { def shouldBe(r: Any) = ??? def arg() = "" this shouldBe (arg) } ``` Without changes in this commit then `this shouldBe (arg)` + will not be rewritten if scalacenter/scalafix#1104 is not fixed + will be rewritten to invalid code `this shouldBe (arg)()` if scalacenter/scalafix#1104 is fixed but scalameta/scalameta#1083 is not fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and scalacenter/scalafix#1104
Given
Without changes in this commit then
this shouldBe (arg)this shouldBe (arg)()if Can't get symbol from TextDocument for arg of ApplyInfix which have parens around scalacenter/scalafix#1104 is fixed but Wrong position for parens wrapped identifier scalameta/scalameta#1083 is not fixed