Wrong position for parens wrapped identifier

[olafurpg]

@ """val x = (a).value""".parse[Stat].get.collect {
    case n: Name => n.syntax
  }
res1: List[String] = List("x", "(a)", "value") // obtained
res1: List[String] = List("x", "a", "value") // expected

This causes problems when looking up symbols of names by their positions.

[olafurpg]

Just hit again on a similar problem

@ """
    List(builder) map (_.result)
  """.parse[Stat].get.collect {
  case t @ q"_.result" => t.syntax
  }
res1: List[String] = List("(_.result)") // obtained
res1: List[String] = List("_.result") // expected

The example works as expected if it's not an ApplyInfix

[olafurpg]

Reported by @MasseGuillaume in #1444

def structure(source: String): String = 
  source.parse[Stat].get.asInstanceOf[Term.ApplyInfix].args.head.tokens.structure 

// This is what I get
structure("a op (f)") == "Tokens(( [5..6), f [6..7), ) [7..8))"

// This is what I expect
structure("a op (f)") == "Tokens(f [6..7))"

// With multiple args I get what I expect
structure("a op (f, g)") == "Tokens(f [6..7))"

[olafurpg]

A good place to look into this would be

scalameta/scalameta/parsers/shared/src/main/scala/scala/meta/internal/parsers/ScalametaParser.scala

Lines 1163 to 1164 in 97e1e8a

	def termName(advance: Boolean = true): Term.Name = name(Term.Name(_), advance)
	def typeName(advance: Boolean = true): Type.Name = name(Type.Name(_), advance)

where Term.Name nodes are created.

[MasseGuillaume]

I'm on this.

[kitbellew]

still relevant? i can't repro.

[olafurpg]

Closing as fixed then :)