Multi out support as non-public API #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| jobs: | ||
| triage: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/labeler@master | ||
| - uses: actions/labeler@main |
There was a problem hiding this comment.
We have no main (yet)?
There was a problem hiding this comment.
I think you mentioned it is not working great, should we remove, or does this fix things?
RayRoestenburg
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal variant of #773 and does not offer multi-out flows or sinks to the public Akka Streamlet API but fixes the Splitter API to guarantee at-least-once.
Introduce a
MultiData2type which serves as a tuple of sequences. The idea is that such a type would make the Java API and the Scala API more uniform.Introduce
MultiProducer(as internal API) which produces to two outlets in parallel and ensures proper committing after all elements are produced.