Bug: Document fetching using views resulted in wrong character encoding (e.g. for Umlauts) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding (e.g. for Umlauts) * Fixed by explicitly using UTF-8 in the InputStreamReader * To be consistent, all InputStreamReader instances have been changed to use UTF-8
ahmedyha
added a commit
that referenced
this pull request
Jul 5, 2015
Bug: Document fetching using views resulted in wrong character encoding (e.g. for Umlauts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
thanks for your great tool, it is really fun to use! I recently stumbled across an encoding issue: fetching documents via views does not encode them in UTF-8. I tried to fix that and also changed all other InputStreamReaders so that it now should consistently be UTF-8 everywhere.
I hope you approve of this change and add it to the trunk.
Cheers,
Sebastian