Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about catalog manifest discrepancy #91

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PaddyAlton
Copy link

@PaddyAlton PaddyAlton commented Jan 19, 2024

N.B. I stacked this PR on top of #90 - it contains those changes as well as the relevant ones for this work.

EDIT: #90 was split in two - this is now a stack of three PRs. Confusingly, the order is #90 -> #92 -> #91 (this PR)


An issue related to discrepancies between the DBT manifest and the DBT catalog caused me trouble earlier this year, and was mentioned by some others, too (DBT Slack).

It isn't explicitly included in an open issue, but is fundamentally related to #5 . That issue is about columns in the catalog that are not in the manifest, whereas my problem was about columns in the manifest that are not in the catalog (i.e. incorrectly documented columns).

I have added some warnings for both situations.

If a column in the manifest is not in the catalog, no column data type can be inferred. An uninformative error is raised when its looker type is mapped (caused by attempting to run None.upper()) - I have instead added an informative Exception, which is raised at the point of data-type inference (instead of returning None for the type, which, as far as I can tell, will always lead to a later error).

@PaddyAlton PaddyAlton changed the title 5 warn about catalog manifest discrepancy Warn about catalog manifest discrepancy Jan 26, 2024
@PaddyAlton PaddyAlton force-pushed the 5-warn-about-catalog-manifest-discrepancy branch from d0535b5 to 8c5a2c3 Compare February 9, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant