feat: add scheduler #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rephus
commented
Apr 19, 2023
•
rephus
commented
rephus
commented
Apr 19, 2023
| @@ -0,0 +1,69 @@ | |||
| apiVersion: apps/v1 | |||
There was a problem hiding this comment.
I've only added a deployment, I guess the ConfigMap is the same than lightdash
rephus
commented
Apr 19, 2023
| key: {{ (include "lightdash.database.secret.passwordKey" .) }} | ||
| envFrom: | ||
| - configMapRef: | ||
| name: {{ .Release.Name }} |
There was a problem hiding this comment.
using the same lightdash configmap by using .Release.Name
owlas
reviewed
Apr 19, 2023
| @@ -8,5 +8,8 @@ dependencies: | |||
| - name: browserless-chrome | |||
| repository: https://charts.sagikazarmark.dev | |||
| version: 0.0.4 | |||
| digest: sha256:e67eebb04f4ad84367593b74cf5dd71a4ee8e5daede54549be6dfea396419064 | |||
| generated: "2023-01-11T20:11:55.264423Z" | |||
| - name: scheduler | |||
There was a problem hiding this comment.
can we call this lightdash-scheduler so it's obviously a lightdash-specific dependency
owlas
reviewed
Apr 19, 2023
| @@ -27,6 +27,7 @@ configMap: | |||
| DBT_PROJECT_DIR: "" | |||
| # -- Public URL of your instance including protocol e.g. https://lightdash.myorg.com | |||
| SITE_URL: "" | |||
| LIGHTDASH_SECRET: 'secret' | |||
There was a problem hiding this comment.
This might be dangerous because by default everybody will use the same encryption key. I think it's better to throw an error if this isn't set. What was the original behaviour?
owlas
reviewed
Apr 19, 2023
| @@ -53,6 +54,7 @@ If you don't want helm to manage this, you may wish to separately create a secre | |||
| | autoscaling.targetCPUUtilizationPercentage | int | `80` | | | |||
| | backendConfig.create | bool | `false` | | | |||
| | browserless-chrome.enabled | bool | `true` | | | |||
| | browserless-chrome.env.CONNECTION_TIMEOUT | string | `"180000"` | | | |||
There was a problem hiding this comment.
do you know why this appeared here?
owlas
reviewed
Apr 19, 2023
| digest: sha256:e67eebb04f4ad84367593b74cf5dd71a4ee8e5daede54549be6dfea396419064 | ||
| generated: "2023-01-11T20:11:55.264423Z" | ||
| - name: scheduler | ||
| repository: "" |
There was a problem hiding this comment.
I think this can be a file uri file://scheduler or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.