Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The tab delete modal should be more explicit about which tiles/c… #9878

Merged
merged 5 commits into from Apr 26, 2024
Merged

fix: The tab delete modal should be more explicit about which tiles/c… #9878

merged 5 commits into from Apr 26, 2024

Conversation

Shifan-Gu
Copy link
Contributor

…harts you will delete

Closes:

  1. when there's saved charts that only belongs to dashboard
Screenshot 2024-04-24 at 13 23 42
  1. when there's no saved chart created within dashboard
Screenshot 2024-04-24 at 13 23 57
  1. when tab has no tiles it will just delete the tab without open the modal

Description:

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited

👷 Deploy request for peaceful-bassi-cbf284 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 7338156

@hamzahc1 hamzahc1 requested a review from rephus April 24, 2024 17:55
@rephus rephus mentioned this pull request Apr 25, 2024
Closed
3 tasks
@owlas owlas requested a deployment to duplicate_fix/improve-delete-tab-ux - jaffle_db_pg_13 PR #9891 April 25, 2024 14:00 — with Render Abandoned
@owlas owlas temporarily deployed to duplicate_fix/improve-delete-tab-ux - headless-browser PR #9891 April 25, 2024 14:00 — with Render Destroyed
@owlas owlas temporarily deployed to duplicate_fix/improve-delete-tab-ux - lightdash PR #9891 April 25, 2024 14:03 — with Render Destroyed
rephus
rephus approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@rephus rephus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@rephus rephus mentioned this pull request Apr 25, 2024
Merged
3 tasks
rephus
rephus requested changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@rephus rephus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error in a test, I tested it manually too.

I can't create save a dashboard with a chart in dashboard. See video:
Screenshot from 2024-04-25 16-45-56

Screencast.from.25-04-24.16.46.28.webm

@Shifan-Gu
Copy link
Contributor Author

Hi @rephus, thank you for the review! i'v put a fix for the issue.

@rephus rephus mentioned this pull request Apr 26, 2024
Closed
3 tasks
@owlas owlas requested a deployment to duplicate_fix/improve-delete-tab-ux2 - jaffle_db_pg_13 PR #9893 April 26, 2024 06:47 — with Render Abandoned
@owlas owlas deployed to duplicate_fix/improve-delete-tab-ux2 - headless-browser PR #9893 April 26, 2024 06:47 — with Render Active
@rephus
Copy link
Collaborator

rephus commented Apr 26, 2024

tested again, it works. Thanks !

@rephus rephus merged commit 1187081 into lightdash:main Apr 26, 2024
54 of 59 checks passed
lightdash-bot pushed a commit that referenced this pull request Apr 26, 2024
@semantic-release-bot
chore(release): 0.1076.6
b6b84f1 
## [0.1076.6](0.1076.5...0.1076.6) (2024-04-26)

### Bug Fixes

* fix foreign constriant error when add chart to dashboard ([#9892](#9892)) ([60987e0](60987e0))
* The tab delete modal should be more explicit about which tiles/c… ([#9878](#9878)) ([1187081](1187081))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1076.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@owlas owlas temporarily deployed to duplicate_fix/improve-delete-tab-ux2 - headless-browser PR #9893 April 29, 2024 17:08 — with Render Destroyed
@owlas owlas temporarily deployed to duplicate_fix/improve-delete-tab-ux2 - lightdash PR #9893 April 29, 2024 17:08 — with Render Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rephus rephus rephus approved these changes

Assignees

@rephus rephus

Labels
released
Projects
Selected for Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shifan-Gu @rephus @lightdash-bot @owlas