-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add funding outpoint sigs to tx_signatures message #1009
Commits on Jun 8, 2021
-
interactive-tx: Add dual-funding flow, using the interactive tx protocol
This commit adds the interactive transaction construction protcol, as well as the first practical example of using it, v2 of channel establishment. Note that for v2 we also update the channel_id, which now uses the hash of the revocation_basepoints. We move away from using the funding transaction id, as the introduction of RBF* makes it such that a single channel may have many funding transaction id's over the course of its lifetime. *Later, also splicing
Configuration menu - View commit details
-
Copy full SHA for bb3eb80 - Browse repository at this point
Copy the full SHA bb3eb80View commit details -
dual-funding: accept_channel2 must also use the temporary channel-id
So that it knows what open_channel2 is responding to. Spotted-By: @rustyrussell
Configuration menu - View commit details
-
Copy full SHA for 07b9ffb - Browse repository at this point
Copy the full SHA 07b9ffbView commit details -
fixup! interactive-tx: Add dual-funding flow, using the interactive t…
…x protocol Suggested-By: Antoine Riard @ariard
Configuration menu - View commit details
-
Copy full SHA for 3dcb9d1 - Browse repository at this point
Copy the full SHA 3dcb9d1View commit details
Commits on Jul 20, 2021
-
fixup: remove fee_step from init_rbf in favor of an explicity feerate
Remove the fee_step in favor of using an explicit bump feerate, with the constraint that it must be at least 1/64th greater than the last sent rate. Suggested-By: @rustyrussell
Configuration menu - View commit details
-
Copy full SHA for b2949cd - Browse repository at this point
Copy the full SHA b2949cdView commit details
Commits on Aug 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 53371fe - Browse repository at this point
Copy the full SHA 53371feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28dfc1c - Browse repository at this point
Copy the full SHA 28dfc1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25af2c6 - Browse repository at this point
Copy the full SHA 25af2c6View commit details -
fixup: remove reference to 'DER' encoding
As @t-bast points out, we define 'point' in 01, which covers the encoding.
Configuration menu - View commit details
-
Copy full SHA for 4eb0029 - Browse repository at this point
Copy the full SHA 4eb0029View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89df351 - Browse repository at this point
Copy the full SHA 89df351View commit details -
Configuration menu - View commit details
-
Copy full SHA for db2bf1d - Browse repository at this point
Copy the full SHA db2bf1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for eaaf6fa - Browse repository at this point
Copy the full SHA eaaf6faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 801166f - Browse repository at this point
Copy the full SHA 801166fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 105213d - Browse repository at this point
Copy the full SHA 105213dView commit details
Commits on Aug 16, 2021
-
fixup: move mention of failing the channel to implementation section
"Failing the channel" may not be the right action in all cases where the interactive construction protocol is used (e.g. closes), so we move reference to it as a mitigation technique specifically to the usage of the interactive protocol in the v2 open sequence. Suggested-By: @t-bast
Configuration menu - View commit details
-
Copy full SHA for c2d1a9b - Browse repository at this point
Copy the full SHA c2d1a9bView commit details -
fixup: use "tx_remove_*" in all places, not "tx_rm_"
Suggested-By: @t-bast
Configuration menu - View commit details
-
Copy full SHA for aedaa3a - Browse repository at this point
Copy the full SHA aedaa3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d33274 - Browse repository at this point
Copy the full SHA 9d33274View commit details -
fixup: remove temp_chan_id reference, rename channel_id to zerod_chan_id
For open_channel2 + accept_channel2 we use the opener's basepoint and a zeroed out point for the accepter. This is because we don't know what the accepter's basepoint is yet. (It's transmitted in accept_channel2) Pointed-Out-By: @t-bast
Configuration menu - View commit details
-
Copy full SHA for 3ad9552 - Browse repository at this point
Copy the full SHA 3ad9552View commit details -
Configuration menu - View commit details
-
Copy full SHA for 996cdf8 - Browse repository at this point
Copy the full SHA 996cdf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8595a97 - Browse repository at this point
Copy the full SHA 8595a97View commit details
Commits on Jan 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4670bec - Browse repository at this point
Copy the full SHA 4670becView commit details -
fixup: show turn based protocol in diagrams
Reported-by: @SomberNight
Configuration menu - View commit details
-
Copy full SHA for f2d4c89 - Browse repository at this point
Copy the full SHA f2d4c89View commit details -
Configuration menu - View commit details
-
Copy full SHA for e582d83 - Browse repository at this point
Copy the full SHA e582d83View commit details -
fixup: add switch stmt for P2SH-wrapped segwit input verification
P2SH-wrapped inputs are segwit inputs and should be eligible for spending, however the spec as written didn't permit them Reported-by: @SomberNight
Configuration menu - View commit details
-
Copy full SHA for 96880f6 - Browse repository at this point
Copy the full SHA 96880f6View commit details -
fixup: disallow P2SH scripts in outputs
P2SH outputs have larger dust requirements than native SegWit (and Taproot) scripts; we disallow the creation of them on funding txs as a they're problematic for relay when allowing dust limits below 546 sats (see lightning#894) Suggested-by: @t-bast
Configuration menu - View commit details
-
Copy full SHA for 9346349 - Browse repository at this point
Copy the full SHA 9346349View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7713de - Browse repository at this point
Copy the full SHA d7713deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17bd7ac - Browse repository at this point
Copy the full SHA 17bd7acView commit details
Commits on Feb 10, 2022
-
input_count of 1 times min witness weight of 110, is 110. not 107 the sum of 612 is correct, however. Reported-By: @SimonVrouwe
Configuration menu - View commit details
-
Copy full SHA for 22de9ef - Browse repository at this point
Copy the full SHA 22de9efView commit details
Commits on Apr 26, 2022
-
* Move RBF inside the interactive-tx protocol * Use same tlvs as open_channel / accept_channel * Require native segwit * Fix a few typos and whitespaces issues (thanks markdown linter)
Configuration menu - View commit details
-
Copy full SHA for adb6272 - Browse repository at this point
Copy the full SHA adb6272View commit details
Commits on Apr 29, 2022
-
Merge pull request rustyrussell#3 from t-bast/dual-funding-tbast
Dual funding proposed codec updates
Configuration menu - View commit details
-
Copy full SHA for cfd82dc - Browse repository at this point
Copy the full SHA cfd82dcView commit details
Commits on May 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 53b740e - Browse repository at this point
Copy the full SHA 53b740eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1687397 - Browse repository at this point
Copy the full SHA 1687397View commit details -
We use 1/24 instead of 1/64 to produce larger steps in fee-bumping.
Configuration menu - View commit details
-
Copy full SHA for 6f3583b - Browse repository at this point
Copy the full SHA 6f3583bView commit details
Commits on May 13, 2022
-
dual-fund: update funding transaction test case
Add signature data, remove wrapped segwit inputs, update calculations to be more explicit about how to figure fee
Configuration menu - View commit details
-
Copy full SHA for 124fcfa - Browse repository at this point
Copy the full SHA 124fcfaView commit details -
dual-fund: tie-break tx_sigs send order on node's pubkey
If both peers contribute an equal amount to a interactive tx, peer with "lower" pubkey sends first
Configuration menu - View commit details
-
Copy full SHA for ba0f679 - Browse repository at this point
Copy the full SHA ba0f679View commit details
Commits on May 16, 2022
-
dual-fund: adjust the minimum witness weight down to 107 (from 110)
The weight of a witness stack for a p2wpkh low-r signature is 107 bytes.
Configuration menu - View commit details
-
Copy full SHA for 8dbba62 - Browse repository at this point
Copy the full SHA 8dbba62View commit details
Commits on May 18, 2022
-
dual-fund: add missing tlv structs to RBF messages
Don't show up in the CLN generator w/o this
Configuration menu - View commit details
-
Copy full SHA for e86d4a5 - Browse repository at this point
Copy the full SHA e86d4a5View commit details
Commits on Jun 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 96dc0b7 - Browse repository at this point
Copy the full SHA 96dc0b7View commit details