Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funding outpoint sigs to tx_signatures message #1009

Closed
wants to merge 37 commits into from

Commits on Jun 8, 2021

  1. interactive-tx: Add dual-funding flow, using the interactive tx protocol

    This commit adds the interactive transaction construction protcol, as
    well as the first practical example of using it, v2 of channel
    establishment.
    
    Note that for v2 we also update the channel_id, which now uses the hash
    of the revocation_basepoints. We move away from using the funding
    transaction id, as the introduction of RBF* makes it such that a single
    channel may have many funding transaction id's over the course of
    its lifetime.
    
    *Later, also splicing
    niftynei committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    bb3eb80 View commit details
    Browse the repository at this point in the history
  2. dual-funding: accept_channel2 must also use the temporary channel-id

    So that it knows what open_channel2 is responding to.
    
    Spotted-By: @rustyrussell
    niftynei committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    07b9ffb View commit details
    Browse the repository at this point in the history
  3. fixup! interactive-tx: Add dual-funding flow, using the interactive t…

    …x protocol
    
    Suggested-By: Antoine Riard @ariard
    niftynei committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    3dcb9d1 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. fixup: remove fee_step from init_rbf in favor of an explicity feerate

    Remove the fee_step in favor of using an explicit bump feerate, with
    the constraint that it must be at least 1/64th greater than the last
    sent rate.
    
    Suggested-By: @rustyrussell
    niftynei committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b2949cd View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. Configuration menu
    Copy the full SHA
    53371fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    28dfc1c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25af2c6 View commit details
    Browse the repository at this point in the history
  4. fixup: remove reference to 'DER' encoding

    As @t-bast points out, we define 'point' in 01, which covers the
    encoding.
    niftynei committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    4eb0029 View commit details
    Browse the repository at this point in the history
  5. fixup: remove errant 'n'

    niftynei committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    89df351 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    db2bf1d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eaaf6fa View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    801166f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    105213d View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. fixup: move mention of failing the channel to implementation section

    "Failing the channel" may not be the right action in all cases where the
    interactive construction protocol is used (e.g. closes), so we move
    reference to it as a mitigation technique specifically to the usage of
    the interactive protocol in the v2 open sequence.
    
    Suggested-By: @t-bast
    niftynei committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    c2d1a9b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aedaa3a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9d33274 View commit details
    Browse the repository at this point in the history
  4. fixup: remove temp_chan_id reference, rename channel_id to zerod_chan_id

    For open_channel2 + accept_channel2 we use the opener's basepoint and a
    zeroed out point for the accepter.  This is because we don't know what
    the accepter's basepoint is yet. (It's transmitted in accept_channel2)
    
    Pointed-Out-By: @t-bast
    niftynei committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    3ad9552 View commit details
    Browse the repository at this point in the history
  5. fixup: add 'it'

    niftynei committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    996cdf8 View commit details
    Browse the repository at this point in the history
  6. fixup: remove 'error' language

    Suggested-By: @t-bast
    niftynei committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    8595a97 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Configuration menu
    Copy the full SHA
    4670bec View commit details
    Browse the repository at this point in the history
  2. fixup: show turn based protocol in diagrams

    Reported-by: @SomberNight
    niftynei committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    f2d4c89 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e582d83 View commit details
    Browse the repository at this point in the history
  4. fixup: add switch stmt for P2SH-wrapped segwit input verification

    P2SH-wrapped inputs are segwit inputs and should be eligible for
    spending, however the spec as written didn't permit them
    
    Reported-by: @SomberNight
    niftynei committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    96880f6 View commit details
    Browse the repository at this point in the history
  5. fixup: disallow P2SH scripts in outputs

    P2SH outputs have larger dust requirements than native SegWit (and
    Taproot) scripts; we disallow the creation of them on funding txs as a
    they're problematic for relay when allowing dust limits below 546 sats
    (see lightning#894)
    
    Suggested-by: @t-bast
    niftynei committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    9346349 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d7713de View commit details
    Browse the repository at this point in the history
  7. v2 opens: add a tx_abort message

    Requested-by: @t-bast
    niftynei committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    17bd7ac View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. fixup: mistake, should be 110

    input_count of 1 times min witness weight of 110, is 110. not 107
    
    the sum of 612 is correct, however.
    
    Reported-By: @SimonVrouwe
    niftynei committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    22de9ef View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Dual funding proposed updates

    * Move RBF inside the interactive-tx protocol
    * Use same tlvs as open_channel / accept_channel
    * Require native segwit
    * Fix a few typos and whitespaces issues (thanks markdown linter)
    t-bast committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    adb6272 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Merge pull request rustyrussell#3 from t-bast/dual-funding-tbast

    Dual funding proposed codec updates
    niftynei committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    cfd82dc View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Fix table of contents

    t-bast authored and niftynei committed May 10, 2022
    Configuration menu
    Copy the full SHA
    53b740e View commit details
    Browse the repository at this point in the history
  2. Fix a few typos

    And add `channel_type` tlv.
    t-bast authored and niftynei committed May 10, 2022
    Configuration menu
    Copy the full SHA
    1687397 View commit details
    Browse the repository at this point in the history
  3. Increase RBF increment

    We use 1/24 instead of 1/64 to produce larger steps in fee-bumping.
    t-bast authored and niftynei committed May 10, 2022
    Configuration menu
    Copy the full SHA
    6f3583b View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. dual-fund: update funding transaction test case

    Add signature data, remove wrapped segwit inputs, update calculations
    to be more explicit about how to figure fee
    niftynei committed May 13, 2022
    Configuration menu
    Copy the full SHA
    124fcfa View commit details
    Browse the repository at this point in the history
  2. dual-fund: tie-break tx_sigs send order on node's pubkey

    If both peers contribute an equal amount to a interactive tx,
    peer with "lower" pubkey sends first
    niftynei committed May 13, 2022
    Configuration menu
    Copy the full SHA
    ba0f679 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. dual-fund: adjust the minimum witness weight down to 107 (from 110)

    The weight of a witness stack for a p2wpkh low-r signature is 107 bytes.
    niftynei committed May 16, 2022
    Configuration menu
    Copy the full SHA
    8dbba62 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. dual-fund: add missing tlv structs to RBF messages

    Don't show up in the CLN generator w/o this
    niftynei committed May 18, 2022
    Configuration menu
    Copy the full SHA
    e86d4a5 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Configuration menu
    Copy the full SHA
    96dc0b7 View commit details
    Browse the repository at this point in the history