Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RFC7539 with RFC8439 #763

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Replace RFC7539 with RFC8439 #763

merged 1 commit into from
Aug 3, 2020

Conversation

yyforyongyu
Copy link
Contributor

7539 is obsoleted by 8439, as mentioned in 7539.

@ysangkok
Copy link
Contributor

ysangkok commented Apr 6, 2020

This fixes #646

@t-bast t-bast mentioned this pull request Aug 3, 2020
Closed
12 tasks
cdecker
cdecker approved these changes Aug 3, 2020
View reviewed changes
Copy link
Collaborator

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

t-bast
t-bast approved these changes Aug 3, 2020
View reviewed changes
Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked briefly at RFC 8439 and the errata filed against 7539, if I didn't miss anything there is no functional change, only clean-up and performance benchmarks added so this looks good!

rustyrussell
rustyrussell approved these changes Aug 3, 2020
View reviewed changes
Copy link
Collaborator

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 3a6039e

cfromknecht
cfromknecht approved these changes Aug 3, 2020
View reviewed changes
Copy link
Collaborator

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-bast t-bast merged commit 50b7391 into lightning:master Aug 3, 2020
@t-bast t-bast mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdecker cdecker cdecker approved these changes

@rustyrussell rustyrussell rustyrussell approved these changes

@cfromknecht cfromknecht cfromknecht approved these changes

@t-bast t-bast t-bast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yyforyongyu @ysangkok @cdecker @rustyrussell @cfromknecht @t-bast