Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: renames RPC feeadjusttoggle to feeadjust-toggle #202

Merged
merged 1 commit into from
Jan 19, 2021
Merged

chore: renames RPC feeadjusttoggle to feeadjust-toggle #202

merged 1 commit into from
Jan 19, 2021

Conversation

m-schmoock
Copy link
Member

After small chat with cdecker, using dash/minus in RPC name is good and will be translated to underscore in pyln on the fly.

@m-schmoock
Copy link
Member Author

@gallizoltan as mentioned earlier ...

@m-schmoock
Copy link
Member Author

Also: do we want feeadjuster-toggle or feeadjust-toggle ? I tend to the first. Second one is only better if we rename the whole plugin, which I dont like.

@gallizoltan
Copy link
Collaborator

tACK fb05a96
Now I can call feeadjuster-toggle (with dash) from command line and feeadjuster_toggle (with underscore) from python RPC.

@gallizoltan
Copy link
Collaborator

Also: do we want feeadjuster-toggle or feeadjust-toggle ? I tend to the first. Second one is only better if we rename the whole plugin, which I dont like.

I think the current feeadjuster-toggle is good in the code. Maybe the commit message could be more precise, but does not matter.

@m-schmoock m-schmoock merged commit 92aafe7 into lightningd:master Jan 19, 2021
@m-schmoock m-schmoock deleted the feeadjusttoggle branch January 19, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-schmoock @gallizoltan