Split wasm output files + check build determinism in CI #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs lightningdevkit/ldk-c-bindings#6, at least. |
TheBlueMatt
force-pushed
the
2021-03-check-determinism
branch
6 times, most recently
from
8629c84
to
de520b1
Compare
|
Note that we probably need at least rust-lang/rust#82102 (ie brand-new-rustc) for the debug binaries to be deterministic. |
TheBlueMatt
force-pushed
the
2021-03-check-determinism
branch
from
de520b1
to
e4bb321
Compare
TheBlueMatt
force-pushed
the
2021-03-check-determinism
branch
from
e4bb321
to
7eef16d
Compare
|
C bindings PR was merged, so this should be good now. |
arik-so
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.