Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have first peer connection trigger announcement broadcast #204

Closed
tnull opened this issue Nov 21, 2023 · 1 comment
Closed

Have first peer connection trigger announcement broadcast #204

tnull opened this issue Nov 21, 2023 · 1 comment

Comments

@tnull
Copy link
Collaborator

tnull commented Nov 21, 2023

Currently, we'd skip broadcasting announcements if we don't have any connected peers to broadcast to.

That is great and we'll retry every 30 seconds, however, it might result in the initial broadcast after startup being always skipped as we spawn the peer connection and broadcast tasks back-to-back, likely resulting in the first iteration of the latter always skipping due to the peers not having been connected yet.

In order to fix this, we should allow the connection task to the broadcast task so that the latter only starts once we're established our initial peer connections.

@tnull
Copy link
Collaborator Author

tnull commented Aug 27, 2024

Not sure that it's really worth the complication. Closing this for now, can always reopen if we stumble across it again.

@tnull tnull closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant