Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to description hash if description is too long #312

Open
tnull opened this issue Jun 17, 2024 · 0 comments
Open

Default to description hash if description is too long #312

tnull opened this issue Jun 17, 2024 · 0 comments

Comments

@tnull
Copy link
Collaborator

tnull commented Jun 17, 2024

Currently, if users provide a description is too long, we would provide a DescriptionTooLong error.

However, we previously received user requests that need to fallback on a description hash in that case. Since we probably don't want to add more methods/parameters to switch the behavior, we should just fall back to using a description hash if the given string is too long.

We should however properly document this, as it might come to some users as a surprise that the actual description string is suddenly missing from the resulting invoice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant