bugfix: Return early if no non-static outputs #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
reviewed
Jul 5, 2023
If there is a cooperative closure, there will only be one output to spend, and it will be a `StaticOutput`. Since `WalletKeysManager`'s `spend_spendable_outputs` filters out static outputs, `KeysManager`'s `spend_spendable_outputs` gets passed an empty list of descriptors to spend, which results in an error (with no further information provided).
MaxFangX
force-pushed
the
max/fix-spend-spendable-outputs
branch
from
1750be4
to
ccf347c
Compare
It would be better if |
tnull
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a cooperative closure, there will only be one output to spend, and it will be a
StaticOutput. SinceWalletKeysManager::spend_spendable_outputsfilters out static outputs,KeysManager::spend_spendable_outputsgets passed an empty list of descriptors to spend, which results in an error (with no further information provided).