add 2825 #28
add 2825 #28
Conversation
✅ Deploy Preview for courageous-frangipane-fab648 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| 1. Did you review the PR? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)? | ||
| 2. What are the main scenarios in Lightning we want to utilizie | ||
| the `OutputSweepeer` intrdouced in this pull request? | ||
| 3. Per this pull request, what are the three conditions for |
There was a problem hiding this comment.
Not sure what three conditions this is exactly referring to? What do you have in mind?
Also, technically you can't 'broadcast an output' just a transaction.
There was a problem hiding this comment.
referring to this https://github.com/lightningdevkit/rust-lightning/pull/2825/files#diff-d3c304325f86fcf7a84425e86192d364907c77356deef4a274b3ef0c936d0bc7R364
-
when the tx was not broadcasted(last else in the function)
} else {// Our first broadcast. -
if latest_broadcast_height + self.regenerate_spend_threshold >= cur_height { -
latest_broadcast_height < cur_height {(rebroadcasting same transaction for each new block if not (2))
There was a problem hiding this comment.
Alright, makes sense. Note that it may help to differentiate between 'broadcasting' and 'regenerate and broadcast' here to give a hint.
jbesraa
force-pushed
the
add-2825
branch
2 times, most recently
from
38d227f
to
7723f5c
Compare
_posts/2024-01-26-#2825.md
Outdated
| date: 2024-01-26 | ||
| title: "Add OutputSweeper persisting and spending outputs " | ||
| pr: 2825 | ||
| authors: [jbesraa] |
There was a problem hiding this comment.
I believe this should be set to the PR author?
| date: 2024-01-26 | ||
| title: "Add OutputSweeper persisting and spending outputs" | ||
| pr: 2825 | ||
| authors: [tnull] |
No description provided.