Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment Retries #93

Open
ConorOkus opened this issue Nov 4, 2021 · 2 comments
Open

Payment Retries #93

ConorOkus opened this issue Nov 4, 2021 · 2 comments
Assignees

Comments

@ConorOkus
Copy link
Contributor

Add a Payment Retries section to Sending Payments.

Includes new InvoicePayer API that retires payments as paths fail.

Released v0.0.103.0
Pull Request

@ConorOkus ConorOkus self-assigned this Nov 8, 2021
@ConorOkus ConorOkus added the documentation Improvements or additions to documentation label Nov 9, 2021
@jkczyz
Copy link
Collaborator

jkczyz commented Nov 11, 2021

Looks like we also need to update both tutorials to use InvoicePayer similarly to how it's used in the sample.

lightningdevkit/ldk-sample#40

@moneyball
Copy link
Contributor

Something Jeff said that I thought would be good to include in our docs:
"Just for clarification there are two things that may be getting conflated here: the scorer and the retrier. The scorer is used when finding a route and when getting events from successful and failed paths. The retrier consumes those events by telling the scorer that a path has failed or succeeded and then retries by querying for a (potentially new) path with the updated scorer. LDK users can use the LDK scorer and their own retry logic, the latter of which delegates to the scorer just as our retrier is doing."

@ConorOkus ConorOkus removed the documentation Improvements or additions to documentation label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants