Skip to content

Commit

Permalink
f - retain to avoid extra alloc in RecipientOnionFields::check_merge
Browse files Browse the repository at this point in the history
  • Loading branch information
alecchendev committed Jun 5, 2023
1 parent a694d2d commit 3483289
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions lightning/src/ln/outbound_payment.rs
Original file line number Diff line number Diff line change
Expand Up @@ -503,11 +503,7 @@ impl RecipientOnionFields {
if self.payment_metadata != further_htlc_fields.payment_metadata { return Err(()); }

if let (Some(tlvs), Some(further_tlvs)) = (&mut self.custom_tlvs, &further_htlc_fields.custom_tlvs) {
let remaining_tlvs = tlvs.iter()
.filter(|tlv| further_tlvs.iter().any(|further_tlv| tlv == &further_tlv))
.map(|tlv| tlv.clone())
.collect();
self.custom_tlvs = Some(remaining_tlvs);
tlvs.retain(|tlv| further_tlvs.iter().any(|further_tlv| tlv == further_tlv));
}
Ok(())
}
Expand Down

0 comments on commit 3483289

Please sign in to comment.