Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support loading a std-persisted ProbabilisticScorer in no-std #2539

Closed
TheBlueMatt opened this issue Aug 29, 2023 · 0 comments · Fixed by #2656
Closed

Support loading a std-persisted ProbabilisticScorer in no-std #2539

TheBlueMatt opened this issue Aug 29, 2023 · 0 comments · Fixed by #2656
Assignees
@TheBlueMatt
Milestone
0.0.119

Comments

@TheBlueMatt
Copy link
Collaborator

This is an important use-case for mobile wallets downloading a scorer from their LSP, and we currently "dont support" it, but it works fine (or should, afaict). We should clarify the comment #2526 (comment)
@TheBlueMatt TheBlueMatt added this to the 0.0.118 milestone Aug 29, 2023
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Oct 12, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
8d184b7 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.118, 0.0.119 Oct 12, 2023
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Nov 1, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
f4fac7c 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
@TheBlueMatt TheBlueMatt linked a pull request Nov 5, 2023 that will close this issue
Stop decaying liquidity information during scoring #2656
Merged
@TheBlueMatt TheBlueMatt self-assigned this Nov 28, 2023
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Nov 29, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
7d1eb8b 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Nov 29, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
a4227e2 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Nov 29, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
2024bba 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 5, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
66b2af5 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 6, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
ff64132 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 6, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
5397c35 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 9, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
91d3b83 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 9, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
5f5ddaf 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 13, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
4df8587 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 13, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
c6ed52d 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 13, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
342ce2f 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 13, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
5aa21c5 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 13, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
81389de 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Dec 15, 2023
@TheBlueMatt
Drop warning about mixing no-std and std ProbabilisticScorers
6d5b439 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
yellowred pushed a commit to yellowred/rust-lightning that referenced this issue Dec 19, 2023
@TheBlueMatt @yellowred
Drop warning about mixing no-std and std ProbabilisticScorers
a19fefa 
Now that the serialization format of `no-std` and `std`
`ProbabilisticScorer`s both just use `Duration` since UNIX epoch
and don't care about time except when decaying, we don't need to
warn users to not mix the scorers across `no-std` and `std` flags.

Fixes lightningdevkit#2539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBlueMatt TheBlueMatt

Labels
None yet
Projects
None yet
Milestone
0.0.119
Development

Successfully merging a pull request may close this issue.

Stop decaying liquidity information during scoring TheBlueMatt/rust-lightning
1 participant
@TheBlueMatt