Pipe filesystem writes in lightning-persister through BufWriter
#1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We generally make no effort to ensure all writes are buffered in lower-level objects, so wrapping write calls in `BufWriter` may substantially improve performance in some cases. This is especially important now that we block the sample node exit until the `NetworkGraph` has been written out, which includes many small-ish writes. With this change, shutdown of the sample node on a relatively underpowered device went from 15-30 seconds of CPU time to a second or two, plus IO sync time.
TheBlueMatt
force-pushed
the
2022-04-buf-writes
branch
from
962ab93
to
7e93fdb
Compare
Codecov Report
@@ Coverage Diff @@
## main #1404 +/- ##
==========================================
- Coverage 90.83% 90.82% -0.01%
==========================================
Files 73 73
Lines 41266 41266
Branches 41266 41266
==========================================
- Hits 37485 37481 -4
- Misses 3781 3785 +4
Continue to review full report at Codecov.
|
valentinewallace
approved these changes
Apr 15, 2022
jkczyz
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generally make no effort to ensure all writes are buffered in
lower-level objects, so wrapping write calls in
BufWritermaysubstantially improve performance in some cases. This is especially
important now that we block the sample node exit until the
NetworkGraphhas been written out, which includes many small-ishwrites.
With this change, shutdown of the sample node on a relatively
underpowered device went from 15-30 seconds of CPU time to a second
or two, plus IO sync time.