Add test coverage for failure of inconsistent MPP parts #1451
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1451 +/- ##
==========================================
+ Coverage 90.88% 90.92% +0.03%
==========================================
Files 75 75
Lines 41474 41663 +189
Branches 41474 41663 +189
==========================================
+ Hits 37695 37881 +186
- Misses 3779 3782 +3
Continue to review full report at Codecov.
|
TheBlueMatt
force-pushed
the
2022-04-moar-mpp-fail-test
branch
from
a7e5050
to
958fa92
Compare
There was a problem hiding this comment.
LGTM, I need only to check in deep the last commit (958fa92)
|
|
||
| let failure_events = nodes[0].node.get_and_clear_pending_events(); | ||
| assert_eq!(failure_events.len(), 2); | ||
| if let Event::PaymentPathFailed { .. } = failure_events[0] {} else { panic!(); } |
There was a problem hiding this comment.
it appears to me here that with the second fail we're actually not panicking. Is the boolean a misnomer?
There was a problem hiding this comment.
Yea, its a bit confusing its really "test that the second fail doesnt panic". I force-pushed a rename to test_for_second_fail_panic to make it clearer.
TheBlueMatt
force-pushed
the
2022-04-moar-mpp-fail-test
branch
from
958fa92
to
acdd2dc
Compare
When we receive multiple HTLCs which claim to be a part of the same MPP but which are inconsistent for some reason, we should fail the inconsistent HTLCs but keep the first HTLCs up until the first inconsistency. This works, but it turns out there was no test coverage, so we add some here.
TheBlueMatt
force-pushed
the
2022-04-moar-mpp-fail-test
branch
from
acdd2dc
to
7a8344a
Compare
|
Rebased after merge of #1435 |
When we receive multiple HTLCs which claim to be a part of the same
MPP but which are inconsistent for some reason, we should fail the
inconsistent HTLCs but keep the first HTLCs up until the first
inconsistency.
This works, but it turns out there was no test coverage, so we add
some here.
Discovered when CI didn't fail even though I noted #1447 (comment)
Based on #1435 because it makes testing MPP routes a ton easier.