Pull secp256k1 contexts from per-peer to per-PeerManager #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1472 +/- ##
==========================================
- Coverage 90.94% 90.94% -0.01%
==========================================
Files 75 75
Lines 41891 41899 +8
Branches 41891 41899 +8
==========================================
+ Hits 38097 38103 +6
- Misses 3794 3796 +2
Continue to review full report at Codecov.
|
TheBlueMatt
force-pushed
the
2022-06-less-secp-ctx
branch
from
3a4258c
to
2ab8814
Compare
dunxen
previously approved these changes
May 10, 2022
Instead of including a `Secp256k1` context per `PeerChannelEncryptor`, which is relatively expensive memory-wise and nontrivial CPU-wise to construct, we should keep one for all peers and simply reuse it. This is relatively trivial so we do so in this commit. Since its trivial to do so, we also take this opportunity to randomize the new PeerManager context.
|
Rebased. |
TheBlueMatt
force-pushed
the
2022-06-less-secp-ctx
branch
from
2ab8814
to
e6aaf7c
Compare
dunxen
approved these changes
May 12, 2022
arik-so
approved these changes
May 16, 2022
valentinewallace
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running some heap profiling on an LDK application and noticed we currently allocate a full secp context per peer, so figured I'd just remove it.
Instead of including a
Secp256k1context perPeerChannelEncryptor, which is relatively expensive memory-wiseand nontrivial CPU-wise to construct, we should keep one for all
peers and simply reuse it.
This is relatively trivial so we do so in this commit.
Since its trivial to do so, we also take this opportunity to
randomize the new PeerManager context.