Outbound payment module follow-up #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
Dec 20, 2022
Codecov ReportBase: 90.78% // Head: 90.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1929 +/- ##
==========================================
- Coverage 90.78% 90.77% -0.02%
==========================================
Files 96 96
Lines 50077 50228 +151
Branches 50077 50228 +151
==========================================
+ Hits 45462 45593 +131
- Misses 4615 4635 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
And expose it in testing only, for safety
valentinewallace
force-pushed
the
2022-12-outbound-payment-mod-followup
branch
from
89e4ab9
to
c756886
Compare
jkczyz
reviewed
Dec 21, 2022
in long method signatures
valentinewallace
force-pushed
the
2022-12-outbound-payment-mod-followup
branch
from
c756886
to
cc60fd6
Compare
jkczyz
approved these changes
Dec 21, 2022
TheBlueMatt
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address outstanding feedback from #1923
Based on #1928