Use the user-provided SleepFuture for interval checks in background-processor
#1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`background-processor` does a number of jobs on various timers. Currently, those are all done by checking the timers every 100ms by interrogating `std::time::Instant`. This is fine for the threaded version, but we'd like more flexibility in the `futures`- based `background-processor`. Here we swap the `std::time::Instant` interrogation for a lambda which we will switch out to the user-provided sleeper in the next commit.
`background-processor` does a number of jobs on various timers. Instead of doing those by interrogating `std::time::Instant`, this change swaps to using the existing user-provided sleep future. Fixes lightningdevkit#1864.
Codecov ReportBase: 90.72% // Head: 90.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1962 +/- ##
==========================================
+ Coverage 90.72% 90.75% +0.03%
==========================================
Files 97 97
Lines 50579 51341 +762
Branches 50579 51341 +762
==========================================
+ Hits 45888 46595 +707
- Misses 4691 4746 +55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wpaulino
reviewed
Jan 17, 2023
|
LGTM after squash. |
arik-so
reviewed
Jan 17, 2023
This makes `background-processor` build without `std` at all. This isn't particularly useful in the general no-std case as `background-processor` is only useful with the `futures` feature, and async will generally need `std` in some way or another. Still, it ensures we don't end up reintroducing a dependency on the current time, which breaks `wasm` use-cases.
TheBlueMatt
force-pushed
the
2023-01-bp-no-std
branch
from
1540f5e
to
aa4c6f6
Compare
arik-so
approved these changes
Jan 17, 2023
wpaulino
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background-processordoes a number of jobs on various timers.Currently, those are all done by checking the timers every 100ms
by interrogating
std::time::Instant. This is fine for thethreaded version, but we'd like more flexibility in the
futures-based
background-processor.Here we swap the
std::time::Instantinterrogation for a lambdawhich we will switch out to the user-provided sleeper for the async futures version.
Fixes #1864.