Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning-net-tokio: Don't require Arc<PeerManager> #1968

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

MaxFangX
Copy link
Contributor

Fixes the last net tokio API quirk where the peer manager parameter was required to be Arc<PeerManager<_>> instead of simply Deref<Target = PeerManager<_>> + Clone.

@codecov-commenter
Copy link

Codecov Report

Base: 90.70% // Head: 90.70% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fce0397) compared to base (437fa4f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1968   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files          97       97           
  Lines       50577    50588   +11     
  Branches    50577    50588   +11     
=======================================
+ Hits        45874    45887   +13     
+ Misses       4703     4701    -2     
Impacted Files Coverage Δ
lightning-net-tokio/src/lib.rs 77.77% <100.00%> (+0.46%) ⬆️
lightning/src/ln/peer_channel_encryptor.rs 93.38% <0.00%> (-0.25%) ⬇️
lightning/src/chain/onchaintx.rs 94.35% <0.00%> (-0.21%) ⬇️
lightning/src/ln/functional_tests.rs 96.98% <0.00%> (-0.04%) ⬇️
lightning/src/ln/channelmanager.rs 87.11% <0.00%> (+<0.01%) ⬆️
lightning-background-processor/src/lib.rs 95.46% <0.00%> (+0.01%) ⬆️
lightning-invoice/src/payment.rs 89.63% <0.00%> (+0.15%) ⬆️
lightning/src/chain/channelmonitor.rs 91.03% <0.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Almost forgot that Clone is implemented on references.

@jkczyz jkczyz merged commit 98417a1 into lightningdevkit:main Jan 18, 2023
@MaxFangX MaxFangX deleted the max/net-tokio-no-arc branch January 18, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants