Remove std::SystemTime from create_phantom_invoice, ref #1978

[Kurtsley]

Also added the "can be used in no_std environment" to the comments above the functions.

[jkczyz]

@TheBlueMatt Do we still want a version that uses SystemTime?

[TheBlueMatt]

I don't have a super strong opinion. I'm pretty annoyed at how many util methods there are in this file, so I kinda like the idea of not adding new ones (and I expect phantom invoice users can figure out how to get the current time), but of course its also nice to not have to supply something that we can figure out for the user...absent a strong opinion I'm happy to move forward as-is.

[TheBlueMatt]

The #[cfg(feature = "std")] bound on the use...PhantomRouteHints needs to be removed.

[TheBlueMatt]

Please squash the fixup into the first commit as described at https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits While you're at it, it would be nice to have an explanation of why you're removing the SystemTime from create_phantom_invoice - something about nostd.

[codecov-commenter]

Codecov Report

Base: 90.91% // Head: 90.91% // No change to project coverage 👍

Coverage data is based on head (d4de913) compared to base (d4de913).
Patch has no changes to coverable lines.

❗ Current head d4de913 differs from pull request most recent head afa0480. Consider uploading reports for the commit afa0480 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1985   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files          99       99           
  Lines       52505    52505           
  Branches    52505    52505           
=======================================
  Hits        47735    47735           
  Misses       4770     4770           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[TheBlueMatt]

You need to replace the .current_timestamp call in _create_phantom_invoice as its not available in no-std.

[Kurtsley]

I'm thinking of just adding another function called timestamp_no_std or something and basically copying the current timestamp function over minus SystemTime. I'm obviously having trouble testing this in a no_std environment. My apologies.

[dunxen]

Can this (and the one below) not just be part of the release notes?

[TheBlueMatt]

Yea, good point, we shouldn't phrase docs in terms of "changes made", they should describe what the function does now.

[TheBlueMatt]

LGTM aside from @dunxen's comment about docs referring to changes. Happy to land as-is if you prefer and we can clean up the docs later, just let me know what you prefer @Kurtsley.

[Kurtsley]

I say merge this and I can open a seperate PR to deal with the docs. Should be able to deal with that tonight.