Make waking after a future completes propagates to the next future #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our `wakers`, if we first `notify` a future, which is then `poll`ed complete, and then `notify` the same waker again before a new future is fetched, that new future will be marked as non-complete initially and wait for a third `notify`. The fix is luckily rather trivial, when we `notify` a future, if it is completed immediately, simply wipe the future state so that we look at the pending-notify flag when we generate the next future.
dunxen
approved these changes
Mar 2, 2023
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2064 +/- ##
==========================================
+ Coverage 87.34% 88.75% +1.40%
==========================================
Files 101 101
Lines 44296 54434 +10138
Branches 44296 54434 +10138
==========================================
+ Hits 38691 48312 +9621
- Misses 5605 6122 +517
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Kicked CI - looks like it was more flakyness on the lightning-transaction-sync tests. |
wpaulino
approved these changes
Mar 2, 2023
MaxFangX
added a commit
to lexe-app/rust-lightning
that referenced
this pull request
Mar 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our
wakers, if we firstnotifya future, which is thenpolled complete, and thennotifythe same waker again before a new future is fetched, that new future will be marked as non-complete initially and wait for a thirdnotify.The fix is luckily rather trivial, when we
notifya future, if it is completed immediately, simply wipe the future state so that we look at the pending-notify flag when we generate the next future.