Expose the node secret key in {Phantom,}KeysManager
#2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
previously approved these changes
Mar 3, 2023
jkczyz
reviewed
Mar 3, 2023
When we removed the private keys from the signing interface we forgot to re-add them in the public interface of our own implementations, which users may need.
TheBlueMatt
force-pushed
the
2023-03-get-key
branch
from
6b2487f
to
029b665
Compare
jkczyz
approved these changes
Mar 3, 2023
wpaulino
approved these changes
Mar 3, 2023
Merged
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
+ Coverage 87.17% 87.19% +0.01%
==========================================
Files 100 100
Lines 44721 44729 +8
Branches 44721 44729 +8
==========================================
+ Hits 38986 39000 +14
+ Misses 5735 5729 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we removed the private keys from the signing interface we forgot to re-add them in the public interface of our own implementations, which users may need.