Support HTTPS Esplora endpoints in lightning-transaction-sync via new feature
#2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2085 +/- ##
==========================================
- Coverage 91.14% 91.13% -0.01%
==========================================
Files 101 101
Lines 48849 48849
Branches 48849 48849
==========================================
- Hits 44521 44520 -1
- Misses 4328 4329 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tnull
force-pushed
the
2023-03-introduce-async-https-feature
branch
from
11fdd70
to
6fb7cca
Compare
jkczyz
reviewed
Mar 8, 2023
tnull
force-pushed
the
2023-03-introduce-async-https-feature
branch
from
6fb7cca
to
2820d4a
Compare
jkczyz
reviewed
Mar 8, 2023
tnull
force-pushed
the
2023-03-introduce-async-https-feature
branch
from
2820d4a
to
d327700
Compare
jkczyz
previously approved these changes
Mar 8, 2023
TheBlueMatt
previously approved these changes
Mar 8, 2023
|
Feel free to squash. |
To support HTTPS endpoints, the async HTTP library `reqwest` needs one of the `-tls` features enabled. While the users could specify this in their own cargo dependencies, we here provide a new `esplora-async-https` feature for conveinience.
tnull
force-pushed
the
2023-03-introduce-async-https-feature
branch
from
d327700
to
09038ee
Compare
Agreed. Squashed commits without further changes. |
jkczyz
approved these changes
Mar 8, 2023
TheBlueMatt
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support HTTPS endpoints, the async HTTP library
reqwestneeds one of the-tlsfeatures enabled. While the users could specify this in their own cargo dependencies, we here provide a newesplora-async-httpsfeature for convenience.I for now refrained of making this enabled by default (i.e., directly adding it to
esplora-async), as all current options for TLS libraries haverustcrequirements of >1.56, and we're still exploring how to lower the MSRV of thelightning-transaction-synccrate.