Test for extra locks held in handle_error unconditionally
#2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`handle_error` must be called without `per_peer_state` mutex or `pending_events` mutex locks held or we may risk deadlocks. Previously we checked this in debug builds in the error path, but not in the success path. As it turns out, `funding_transaction_generated`'s error path does hold a `per_peer_state` lock, which we fix here as well as move the tests to happen unconditionally.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
+ Coverage 91.30% 91.81% +0.50%
==========================================
Files 102 102
Lines 49927 54196 +4269
Branches 49927 54196 +4269
==========================================
+ Hits 45586 49760 +4174
- Misses 4341 4436 +95
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dunxen
previously approved these changes
Apr 6, 2023
wpaulino
previously approved these changes
Apr 7, 2023
wpaulino
approved these changes
Apr 7, 2023
dunxen
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle_errormust be called withoutper_peer_statemutex orpending_eventsmutex locks held or we may risk deadlocks. Previously we checked this in debug builds in the error path, but not in the success path.As it turns out,
funding_transaction_generated's error path does hold aper_peer_statelock, which we fix here as well as move the tests to happen unconditionally.