Fix deserialization of u16 arrays #2191
Conversation
u16 arrays are used in the historical liquidity range tracker. Previously, we read them without applying the stride multiple, reading bytes repeatedly and at an offset, corrupting data as we go. This applies the correct stride multiplayer fixing the issue.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
- Coverage 91.35% 91.35% -0.01%
==========================================
Files 102 102
Lines 50382 50382
Branches 50382 50382
==========================================
- Hits 46027 46024 -3
- Misses 4355 4358 +3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Yea, always gave garbage :(. Its only used in the ProbabilisticScorer for the historical bucket tracker. |
|
We'll want to note in the release notes that people probably have corrupted scorers and they should consider wiping it on upgrade 😭 |
u16 arrays are used in the historical liquidity range tracker. Previously, we read them without applying the stride multiple, reading bytes repeatedly and at an offset, corrupting data as we go.
This applies the correct stride multiplayer fixing the issue.