Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose description from Invoice's offer/refund #2206

Merged

Conversation

jkczyz
Copy link
Contributor

@jkczyz jkczyz commented Apr 20, 2023

This will allow clients like VLS to check the description for an invoice as part of verification. (cc: @ksedgwic)

This will allow clients like VLS to check the description for an invoice
as part of verification.
@jkczyz jkczyz force-pushed the 2023-04-invoice-description branch from 8a81e71 to 4ac68f9 Compare April 20, 2023 13:41
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lightning/src/ln/channelmanager.rs Outdated Show resolved Hide resolved
@jkczyz jkczyz force-pushed the 2023-04-invoice-description branch from 4ac68f9 to 42a772d Compare April 20, 2023 15:46
@ksedgwic
Copy link
Contributor

Works with my code, thanks!

@TheBlueMatt TheBlueMatt merged commit a7600dc into lightningdevkit:main Apr 20, 2023
14 checks passed
@jkczyz jkczyz mentioned this pull request May 10, 2023
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants