Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ariard key from the security team #2323

Merged

Conversation

ariard
Copy link

@ariard ariard commented May 28, 2023

I think this is the decision dictated by wisdom. One has always to keep in mind the end users interests and put ego on the side. In the current state of the things if there is another dispute between the other members of the security team and myself like we had during the past months, whatever the reasons, we are more at risks to break LDK users funds safety. This is a free initiative of my own, I didn't receive threats or intimidations from other LDK contributors to do so, really.

There is no need to assign blame or seek who is right or wrong. Trust has been lost on all sides, it's something so frail that take years to build, and yet that can burn in the lapse of an hour. I don't think anymore we'll be able to rebuild it, all characters involved are quite strong and they're following their own life trails. Fact is I’m not aligned with the work culture as shared by the majority of LDK contributors and this culture is not something I wish to be part of, even if it comes with a certain cost on my side.

Rather to loose ourselves in stupid fights every week, I think it's better to take a leave of absence, there is so many more hard problems to solve and beautiful things to build waiting on the corner. The more important focus to keep in mind is making your own life an artwork and this is so short a thing, beyond more vanishing pretensions of the ego.

I won't deny the decision is also tainted by long-term legal considerations and risks of all kinds we're all facing as Bitcoin FOSS developers and the LDK project as a whole. I would have prefer to face those challenges alltogether. In the lack of unity, sapience inspires in the present situation to remove myself from any responsibility.

This PR can be merged ASAP, thanks to remove myself from all the LDK GH repositories, including the security one. I don't really need to be involved with weekly LDK to build the things I'm interested to build in the Bitcoin ecosystem. I’m still do few code reviews though more for my intellectual curiosity than anything else. And thanks for all the interesting things I’ve learnt along the years actively contributing on this open-source project with great people.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.82 🎉

Comparison is base (d7f6e34) 90.90% compared to head (34322e1) 91.72%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2323      +/-   ##
==========================================
+ Coverage   90.90%   91.72%   +0.82%     
==========================================
  Files         104      104              
  Lines       52838    59866    +7028     
  Branches    52838    59866    +7028     
==========================================
+ Hits        48032    54912    +6880     
- Misses       4806     4954     +148     

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, if you'd like, will do.

@ariard
Copy link
Author

ariard commented May 29, 2023

I cannot approve my own pull request @wpaulino or @jkczyz can approve this pull request and that way @TheBlueMatt or anyone else can merge it.

Happy to move on.

@ariard
Copy link
Author

ariard commented May 29, 2023

@TheBlueMatt If you can merge it. Thanks bro.

@TheBlueMatt TheBlueMatt merged commit a9d49ae into lightningdevkit:main May 29, 2023
14 checks passed
@ariard
Copy link
Author

ariard commented May 29, 2023

Thanks in case of discovery of future LDK/Lightning security vulnerabilities, I’ll report them to security@lightningdevkit.org with the industry standard 90 days of embargo (or more if needed) and the respect of infosec ethical rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants