Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support atomic partial updates to ChannelConfig #2330

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

wvanlint
Copy link
Contributor

@wvanlint wvanlint commented Jun 2, 2023

No description provided.

@wvanlint wvanlint force-pushed the partial_config_updates branch 2 times, most recently from 9591d62 to f278af9 Compare June 2, 2023 16:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Patch coverage: 95.83% and project coverage change: -0.01 ⚠️

Comparison is base (fb140b5) 90.34% compared to head (7b22e7b) 90.34%.

❗ Current head 7b22e7b differs from pull request most recent head 8fd8966. Consider uploading reports for the commit 8fd8966 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   90.34%   90.34%   -0.01%     
==========================================
  Files         104      104              
  Lines       53392    53461      +69     
  Branches    53392    53461      +69     
==========================================
+ Hits        48237    48298      +61     
- Misses       5155     5163       +8     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 86.37% <93.87%> (+0.08%) ⬆️
lightning/src/util/config.rs 58.33% <100.00%> (+15.71%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wvanlint wvanlint marked this pull request as ready for review June 5, 2023 15:57
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please squash the fixup commit down when you next push!

lightning/src/util/config.rs Outdated Show resolved Hide resolved
@TheBlueMatt TheBlueMatt merged commit 583a5b2 into lightningdevkit:main Jun 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants