Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min mempool estimate for feerate updates on anchor channels #2415

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Add min mempool estimate for feerate updates on anchor channels #2415

merged 3 commits into from
Jul 17, 2023

Commits on Jul 14, 2023

  1. Add new ConfirmationTarget variant for min mempool feerates 

    Now that we support channels with anchor outputs, we add a new
ConfirmationTarget variant that, for now, will only apply to such
channels. This new variant should target estimating the minimum feerate
required to be accepted into most node mempools across the network.
    @wpaulino
    wpaulino committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    db3d58c View commit details
    Browse the repository at this point in the history

  2. Relax constraints for inbound feerate updates on anchor channels 

    Channels supporting anchors outputs no longer require their feerate
updates to target a prompt confirmation since commitment transactions
can be bumped when broadcasting. Commitment transactions must now at
least meet the minimum mempool feerate, until package relay is deployed,
such that they can propagate across node mempools in the network by
themselves.

The existing higher bound no longer applies to channels supporting
anchor outputs since their HTLC transactions don't have any fees
committed, which directly impact the available balance users can send.
    @wpaulino
    wpaulino committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    1349ac8 View commit details
    Browse the repository at this point in the history

  3. Use min mempool feerate for outbound updates on anchor channels 

    As done with inbound feerate updates, we can afford to commit less in
fees, as long as we still may the minimum mempool feerate. This enables
users to spend a bit more of their balance, as less funds are being
committed to transaction fees.
    @wpaulino
    wpaulino committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    7751cb9 View commit details
    Browse the repository at this point in the history