Fix MSRV tests and drop internet-required test #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`blockstream.info` is currently down, causing our CI to fail. This shouldn't really be a thing, so we drop the blockstream.info-based test here. More generally, I'm not really a fan of having tests which run (outside of CI) and call out to external servers - a developer working on LDK shouldn't have to have internet access to run our test suite and shouldn't be registering their presence with a third party to run our tests.
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2577 +/- ##
========================================
Coverage 90.61% 90.62%
========================================
Files 112 113 +1
Lines 58859 59217 +358
Branches 58859 59217 +358
========================================
+ Hits 53335 53665 +330
- Misses 5524 5552 +28
☔ View full report in Codecov by Sentry. |
|
Still a few CI fails |
TheBlueMatt
force-pushed
the
2023-09-msrv
branch
from
2437f51
to
1f41457
Compare
tnull
reviewed
Sep 15, 2023
|
|
||
| #[tokio::test] | ||
| #[cfg(any(feature = "esplora-async-https", feature = "esplora-blocking"))] | ||
| async fn test_esplora_connects_to_public_server() { |
There was a problem hiding this comment.
Def. ACK on dropping this as it was a crutch anyways. I had originally added this as a regression test as we previously missed the https feature, which only yielded an error when connecting to HTTPS endpoints during runtime, and this was the easiest way to assert we can connect without issue.
ci/ci-tests.sh
Outdated
| # The memchr crate switched to an MSRV of 1.60 starting with v2.6.0 | ||
| # This is currently only a release dependency via core2, which we intend to work with | ||
| # rust-bitcoin to remove soon. | ||
| [ "$RUSTC_MINOR_VERSION" -lt 60 ] && cargo update -p memchr --precise "2.5.0" --verbose |
There was a problem hiding this comment.
Weirdly this fails (sometimes) in CI due to
+ cargo update -p memchr --precise 2.5.0 --verbose
error: package ID specification `memchr` did not match any packages
Error: Process completed with exit code 101.
We're working with rust-bitcoin to remove the `core2` dependency at rust-bitcoin/rust-bitcoin#2066 but until that lands and we can upgrade rust-bitcoin we're stuck with it. In the mean time, we should still pass our MSRV tests.
TheBlueMatt
force-pushed
the
2023-09-msrv
branch
from
1f41457
to
ba12a86
Compare
valentinewallace
approved these changes
Sep 15, 2023
tnull
approved these changes
Sep 15, 2023
|
... and the merge commit fails CI again... 🫠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.