Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Debug for MonitorUpdateId #2594

Merged

Conversation

benthecarman
Copy link
Contributor

Playing around with 117 and trying to log MonitorUpdateId but can't because it doesn't implement Debug

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (a37a16a) 88.86% compared to head (66821a9) 88.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2594      +/-   ##
==========================================
- Coverage   88.86%   88.78%   -0.09%     
==========================================
  Files         113      113              
  Lines       84419    84419              
  Branches    84419    84419              
==========================================
- Hits        75022    74951      -71     
- Misses       7197     7256      +59     
- Partials     2200     2212      +12     
Files Changed Coverage Δ
lightning/src/chain/chainmonitor.rs 89.24% <0.00%> (-0.21%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt TheBlueMatt added this to the 0.0.117 milestone Sep 25, 2023
@TheBlueMatt TheBlueMatt merged commit a87f381 into lightningdevkit:main Sep 25, 2023
15 checks passed
@benthecarman benthecarman deleted the debug-monitor-update-id branch September 25, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants