Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Hash for SpendableOutputDescriptor #2602

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

This allows for easy descriptor de-duplication before building a claiming transaction.

This allows for easy descriptor de-duplication before building a
claiming transaction.
@TheBlueMatt TheBlueMatt added this to the 0.0.117 milestone Sep 26, 2023
@TheBlueMatt
Copy link
Collaborator Author

Trivial and user-requested, tagging 117.

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1ac53ed) 88.84% compared to head (8a42d55) 88.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2602   +/-   ##
=======================================
  Coverage   88.84%   88.85%           
=======================================
  Files         113      113           
  Lines       84729    84729           
  Branches    84729    84729           
=======================================
+ Hits        75275    75282    +7     
- Misses       7240     7241    +1     
+ Partials     2214     2206    -8     
Files Coverage Δ
lightning/src/sign/mod.rs 74.40% <0.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@tlulu tlulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth updating the docs to indicate Hash can be used as unique identifier?

@TheBlueMatt
Copy link
Collaborator Author

I think its implied, at least if you're using a hasher which is sufficiently strong (the default one is siphash returning a 64-bit int, so it should be fine...). In any case, the usual Rust hash API applies.

@TheBlueMatt TheBlueMatt merged commit 7d5f137 into lightningdevkit:main Sep 27, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants