Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have methods take AChannelManager as Deref::Target #2652

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Oct 6, 2023

In #2535, we had lightning-invoice use the AChannelManager trait to clean up the trait boundaries.

While we now gave it as a &C, we can relax that requirement further and instead have C: Deref targetting AChannelManager.

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6016101) 89.03% compared to head (808e72a) 90.07%.
Report is 80 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2652      +/-   ##
==========================================
+ Coverage   89.03%   90.07%   +1.03%     
==========================================
  Files         112      112              
  Lines       86351    94845    +8494     
  Branches    86351    94845    +8494     
==========================================
+ Hits        76879    85427    +8548     
+ Misses       7235     7131     -104     
- Partials     2237     2287      +50     
Files Coverage Δ
lightning-invoice/src/payment.rs 77.48% <66.66%> (+0.17%) ⬆️

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull tnull merged commit 989304e into lightningdevkit:main Oct 8, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants