Consider anchor outputs value throughout balance checks and computations #2674
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2674 +/- ##
==========================================
- Coverage 88.80% 88.74% -0.06%
==========================================
Files 112 112
Lines 88282 88377 +95
Branches 88282 88377 +95
==========================================
+ Hits 78397 78431 +34
- Misses 7636 7689 +53
- Partials 2249 2257 +8
☔ View full report in Codecov by Sentry. |
wpaulino
force-pushed
the
consider-anchor-outputs-value-balances
branch
from
90da6cc
to
568f169
Compare
|
Would be nice if the anchor outputs value was publicly exposed for a channel as well |
It's a static value of 330 sats per output. We have a constant for it but it's not public in the API. Is there some place you had in mind where we should expose it? |
|
Seems like a thing to do in #2618. |
|
Do you want to go ahead and rebase on #2660? |
This could lead us to sending/forwarding HTLCs that would put us below our reserve, forcing our counterparty to close the channel on us due to an invalid update.
This could lead us to accept HTLCs that would put the sender below their reserve, which must never happen.
We should make sure the funding amount of a channel can cover all its associated costs, including the value of anchor outputs, to make sure that it is actually usable once "opened".
Anchor outputs channels are no longer susceptible to fee spikes as they now mostly target the dynamic minimum mempool fee and can contribute the remainder of fees when closing.
wpaulino
force-pushed
the
consider-anchor-outputs-value-balances
branch
from
568f169
to
27fba2d
Compare
| }; | ||
| let commitment_feerate = fee_estimator.bounded_sat_per_1000_weight(commitment_conf_target); | ||
|
|
||
| let value_to_self_msat = channel_value_satoshis * 1000 - push_msat; | ||
| let commitment_tx_fee = commit_tx_fee_msat(commitment_feerate, MIN_AFFORDABLE_HTLC_COUNT, &channel_type); | ||
| if value_to_self_msat < commitment_tx_fee { | ||
| if value_to_self_msat.saturating_sub(anchor_outputs_value_msat) < commitment_tx_fee { |
There was a problem hiding this comment.
Why not adjust for this in commit_tx_fee_msat?
Fixes #2672.