Added temporary_channel_id to create_channel.
#2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhrheaume
force-pushed
the
mhr/temporary_channel_id
branch
2 times, most recently
from
f383319
to
6d0ab1c
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2699 +/- ##
==========================================
+ Coverage 88.78% 88.79% +0.01%
==========================================
Files 113 113
Lines 89116 89126 +10
Branches 89116 89126 +10
==========================================
+ Hits 79123 79143 +20
+ Misses 7752 7735 -17
- Partials 2241 2248 +7
☔ View full report in Codecov by Sentry. |
wpaulino
reviewed
Nov 1, 2023
mhrheaume
force-pushed
the
mhr/temporary_channel_id
branch
from
6d0ab1c
to
5003e7a
Compare
|
LGTM after CI is fixed |
mhrheaume
force-pushed
the
mhr/temporary_channel_id
branch
from
5003e7a
to
5f88eb4
Compare
wpaulino
previously approved these changes
Nov 3, 2023
G8XSU
approved these changes
Nov 3, 2023
lightning/src/ln/channel.rs
Outdated
| @@ -5876,7 +5876,7 @@ impl<SP: Deref> OutboundV1Channel<SP> where SP::Target: SignerProvider { | |||
| pub fn new<ES: Deref, F: Deref>( | |||
| fee_estimator: &LowerBoundedFeeEstimator<F>, entropy_source: &ES, signer_provider: &SP, counterparty_node_id: PublicKey, their_features: &InitFeatures, | |||
| channel_value_satoshis: u64, push_msat: u64, user_id: u128, config: &UserConfig, current_chain_height: u32, | |||
| outbound_scid_alias: u64 | |||
| outbound_scid_alias: u64, temporary_channel_id_opt: Option<ChannelId> | |||
There was a problem hiding this comment.
in channel_manager public api we named it just "temporary_channel_id", lets rename to that for consistency.
There was a problem hiding this comment.
I figured I wouldn't be able to do that because I do let temporary_channel_id = ... below, but it looks like Rust allows it!
mhrheaume
force-pushed
the
mhr/temporary_channel_id
branch
from
5f88eb4
to
2b8bbf1
Compare
wpaulino
approved these changes
Nov 3, 2023
By default, LDK will generate the initial temporary channel ID for you. However, in certain cases, it's desirable to have a temporary channel ID specified by the caller in case of any pre-negotiation that needs to happen between peers prior to the channel open message. For example, LND has a `FundingShim` API that allows for advanced funding flows based on the temporary channel ID of the channel. This patch adds support for optionally specifying the temporary channel ID of the channel through the `create_channel` API.
mhrheaume
force-pushed
the
mhr/temporary_channel_id
branch
from
2b8bbf1
to
bf39507
Compare
TheBlueMatt
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, LDK will generate the initial temporary channel ID for you. However, in certain cases, it's desirable to have a temporary channel ID specified by the caller in case of any pre-negotiation that needs to happen between peers prior to the channel open message. For example, LND has a
FundingShimAPI that allows for advanced funding flows based on the temporary channel ID of the channel.This patch adds support for optionally specifying the temporary channel ID of the channel through the
create_channelAPI.