Add channel_keys_id as param in get_destination_script to support gen…

[rmalonson]

…erating a different destination script for each channel.

[codecov-commenter]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fa0d015) 88.54% compared to head (f53e911) 88.52%.

❗ Current head f53e911 differs from pull request most recent head 7f0fd86. Consider uploading reports for the commit 7f0fd86 to get more accurate results

Files	Patch %	Lines
lightning/src/ln/channel.rs	66.66%	1 Missing ⚠️
lightning/src/util/test_utils.rs	50.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2744      +/-   ##
==========================================
- Coverage   88.54%   88.52%   -0.03%     
==========================================
  Files         113      113              
  Lines       89355    89330      -25     
  Branches    89355    89330      -25     
==========================================
- Hits        79119    79075      -44     
- Misses       7864     7883      +19     
  Partials     2372     2372              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wpaulino]

LGTM, please amend the commit message to follow our guidelines https://cbea.ms/git-commit/.

[rmalonson]

LGTM, please amend the commit message to follow our guidelines https://cbea.ms/git-commit/.

Done

[benthecarman]

Is there a way to reference a key id to a channel? Would be nice so we can see a transaction to a given address and know which channel it was for

[wpaulino]

You should be able to map the user_channel_id to channel_keys_id via SignerProvider::generate_channel_keys_id. Does that work for you?

[benthecarman]

Yeah that'd work

[shaavan]

Awesome work on the new code—it's looking really clean and clear!

I was curious if there were any chats or discussions leading up to this change. If so, could you point me in that direction?

Also, thinking about the impact of this change, I think it might be a good idea to update the comments for the get_destination_script, indicating why are we (now) passing the channel_keys_id as an argument.

[wpaulino]

Needs a rebase

[rmalonson]

Needs a rebase

Done

[rmalonson]

Awesome work on the new code—it's looking really clean and clear!

I was curious if there were any chats or discussions leading up to this change. If so, could you point me in that direction?

Also, thinking about the impact of this change, I think it might be a good idea to update the comments for the get_destination_script, indicating why are we (now) passing the channel_keys_id as an argument.

Thanks! Yes, this was briefly discussed in the Lightspark discord channel here. And I've updated the description for get_destination_script to include the reasoning for channel_keys_id.