Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2128 follow-ups #2801

Merged
merged 11 commits into from Jan 11, 2024
Merged

#2128 follow-ups #2801

merged 11 commits into from Jan 11, 2024

Commits on Jan 10, 2024

  1. Remove trailing whitespace.

    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    be134d1 View commit details
    Browse the repository at this point in the history

  2. Rename InboundOnionErr to InboundHTLCErr. 

    The prior name seems to reference onion decode errors specifically, when in
fact the error contents are generic failure codes for any error that occurs
during HTLC receipt.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    95a5ab9 View commit details
    Browse the repository at this point in the history

  3. Rename outgoing_cltv_value internal var. 

    There is no outgoing CLTV for received HTLCs, so this new var makes more sense.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    cadea5d View commit details
    Browse the repository at this point in the history

  4. Rename InboundOnionPayload::Receive::outgoing_cltv_value 

    .. since there is no outgoing cltv for received HTLCs.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b8fa547 View commit details
    Browse the repository at this point in the history

  5. Rename InboundOnionPayload::BlindedReceive::outgoing_cltv_value. 

    There is no outgoing HTLC for received HTLCs, so rename to be more accurate.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    7c3ef19 View commit details
    Browse the repository at this point in the history

  6. Rename OutboundOnionPayload::Receive::outgoing_cltv_value. 

    There is no outgoing HTLC for received HTLCs, so rename to be more accurate.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4d38ee6 View commit details
    Browse the repository at this point in the history

  7. Rename OutboundOnionPayload::BlindedReceive::outgoing_cltv_value. 

    There is no outgoing HTLC for received HTLCs, so rename to be more accurate.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    aace2d3 View commit details
    Browse the repository at this point in the history

  8. Rename InboundOnionPayload::Receive::amt_msat to be more descriptive.

    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    2d58297 View commit details
    Browse the repository at this point in the history

  9. Rename InboundOnionPayload::BlindedReceive::amt_msat to be more descr… 

    …iptive.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    2b1c994 View commit details
    Browse the repository at this point in the history

  10. Rename OutboundOnionPayload::Receive::amt_msat to be more descriptive.

    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    c76d74a View commit details
    Browse the repository at this point in the history

  11. Rename OutboundOnionPayload::BlindedReceive::amt_msat to be more desc… 

    …riptive.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b20a9ad View commit details
    Browse the repository at this point in the history